Skip to content

feat(qdrant): Async Client Added for QdrantVectorStore #32196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat(qdrant): Async Client Added for QdrantVectorStore #32196

wants to merge 19 commits into from

Conversation

keenborder786
Copy link
Contributor

@keenborder786 keenborder786 commented Jul 23, 2025 •
edited by mdrxy
Loading

@vercel Vercel
Copy link

vercel bot commented Jul 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2025 0:33am

@keenborder786 keenborder786 marked this pull request as draft July 23, 2025 00:03
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 23, 2025 •
edited
Loading

CodSpeed WallTime Performance Report

Merging #32196 will not alter performance

Comparing keenborder786:feat/add_async_client (6e095e2) with master (ba83f58)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 23, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #32196 will not alter performance

Comparing keenborder786:feat/add_async_client (6e095e2) with master (ba83f58)

Summary

✅ 14 untouched benchmarks

sglebs
sglebs reviewed Jul 23, 2025
View reviewed changes
libs/partners/qdrant/langchain_qdrant/qdrant.py Outdated
):
# If we're in an existing event loop, use it directly
loop = asyncio.get_event_loop()
loop.run_until_complete(_validate())
Copy link

@sglebs sglebs Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this patch from FastAPI and it explodes here in line 232:

File "uvloop/loop.pyx", line 1512, in uvloop.loop.Loop.run_until_complete
File "uvloop/loop.pyx", line 1505, in uvloop.loop.Loop.run_until_complete
File "uvloop/loop.pyx", line 1379, in uvloop.loop.Loop.run_forever
File "uvloop/loop.pyx", line 520, in uvloop.loop.Loop._run
RuntimeError: this event loop is already running.

But this worked:

asyncio.ensure_future(_validate()) # and NOT loop.run_until_complete(_validate())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@keenborder786 keenborder786 changed the title feat(langchain_qdrant): Async Client Added for QdrantVectorStore feat(qdrant): Async Client Added for QdrantVectorStore Jul 26, 2025
@keenborder786 keenborder786 marked this pull request as ready for review July 26, 2025 23:36
@keenborder786
Copy link
Contributor Author

@ sglebs please check now

@keenborder786
Copy link
Contributor Author

@ccurme

1 similar comment
@keenborder786
Copy link
Contributor Author

@ccurme

@keenborder786
Copy link
Contributor Author

@mdrxy

@keenborder786 keenborder786 mentioned this pull request Jul 29, 2025
Open
7 tasks
@keenborder786
Copy link
Contributor Author

@sglebs

@keenborder786
Copy link
Contributor Author

@ccurme can you please review it.

@keenborder786
Copy link
Contributor Author

@mdrxy

@keenborder786
Copy link
Contributor Author

@mdrxy can you please review this?

@mdrxy
Copy link
Collaborator

mdrxy commented Aug 3, 2025

@keenborder786 Stop repeatedly tagging maintainers in your PRs.

@keenborder786
Copy link
Contributor Author

@keenborder786 Stop repeatedly tagging maintainers in your PRs.

Hahah, will keep it limited now.

@keenborder786
Copy link
Contributor Author

@mdrxy just reminding to review. Sorry to tag you again.

@keenborder786
Copy link
Contributor Author

@sglebs, weere you able to review it?

@mdrxy mdrxy added the integration Related to a provider partner package integration label Aug 20, 2025
@Huarong
Copy link

Huarong commented Sep 9, 2025

@keenborder786 why was this be closed?

@mdrxy mdrxy reopened this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sglebs sglebs sglebs left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
integration Related to a provider partner package integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QdrantVectorStore cannot be used in a truly async form, no alternative is provided
4 participants
@keenborder786 @mdrxy @Huarong @sglebs